Skip to content

Conversation

suchapalaver
Copy link
Contributor

Thanks to @matthewdarwin for flagging the need for an update!


Signed off by Joseph Livesey [email protected]

@suchapalaver suchapalaver requested a review from a team as a code owner July 9, 2025 15:33
Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks like you updated the file in the wrong language (pages/es instead of pages/en). Also, there are weird formatting changes – I recommend running pnpm check:fix after making changes (but before committing them), if you don't have the Prettier extension installed and format on save enabled.

Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Contributor

@idalithb idalithb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Minor suggested edits, but LGTM!
  • Happy with the reorganization of this 😄

- [Graph TAP Arbitrum One Subgraph (for The Graph mainnet)](https://thegraph.com/explorer/subgraphs/4sukbNVTzGELnhdnpyPqsf1QqtzNHEYKKmJkgaT8z6M1)

> Note: `indexer-agent` does not currently handle the indexing of this Subgraph like it does for the network Subgraph deployment. As a result, you have to index it manually.
> Note: `indexer-agent` does not currently handle the indexing of this subgraph like it does for the network subgraph deployment. You must index it manually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Note: `indexer-agent` does not currently handle the indexing of this subgraph like it does for the network subgraph deployment. You must index it manually.
> Note: `indexer-agent` does not currently handle the indexing of this Subgraph like it does for the network Subgraph deployment. You must index it manually.
  • the style guide will be updated to reflect cap preference

# Locally indexing the Subgraph is recommended.
# NOTE: Use `query_url` or `deployment_id` only
deployment_id = "Qmaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
# The Graph Network subgraph (use query_url OR deployment_id, not both)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# The Graph Network subgraph (use query_url OR deployment_id, not both)
# The Graph Network Subgraph (use query_url OR deployment_id, not both)

# Locally indexing the Subgraph is recommended.
# NOTE: Use `query_url` or `deployment_id` only
deployment_id = "Qmaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
# TAP Escrow subgraph (use query_url OR deployment_id, not both)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TAP Escrow subgraph (use query_url OR deployment_id, not both)
# TAP Escrow Subgraph (use query_url OR deployment_id, not both)

Signed-off-by: Joseph Livesey <[email protected]>
@idalithb idalithb merged commit e0c4ccc into graphprotocol:main Jul 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants